add replacement suggestion to frexp(::Array{<:AbstractFloat}) deprecation #21991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If there's no direct replacement for the functionality, why was it deprecated? It seems somewhat misleading to suggest a replacement that doesn't quite do the same thing. |
Ref. discussion in #19817.
Better to suggest the closest analog (which per the discussion in #19817 should replace uses of this method one way or another) than nothing at all? Best! |
|
Thanks for the link, that makes sense. |
ararslan
approved these changes
May 20, 2017
|
(Absent objections, requests for time, or someone beating me to it, I plan to merge this tomorrow morning. Best!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. #21475. The news aspect of this deprecation should be covered by the broad news entry for deprecation of vectorized methods. This pull request makes the deprecation warning slightly more helpful. Best!